Add ember-data v4.12 to test coverage#738
Closed
fsmanuel wants to merge 2 commits intoupdate-ember-cli-to-4-12from
Closed
Add ember-data v4.12 to test coverage#738fsmanuel wants to merge 2 commits intoupdate-ember-cli-to-4-12from
fsmanuel wants to merge 2 commits intoupdate-ember-cli-to-4-12from
Conversation
We don’t change the package node requirements so it’s not a breaking change but to test against ember-data v4.12 we need node v16.
fsmanuel
force-pushed
the
update-ember-data-to-4-12
branch
from
9bf3c2e to
3807cd0
Compare
fsmanuel
changed the title
Contributor
|
if we're not testing against Node 14 then it's going to be impossible to maintain support for it. I ended up bumping the default ember-data version in #743 but got around the engines issue by using |
Contributor
Author
|
@mansona nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don’t change the package node requirements so it’s not a breaking change but to test against ember-data v4.12 we need node v16 in CI.